Editing John Mills (section)

===Film===

{| class="wikitable" style="font-size: 100%;"
|-
! Year
! Title
! Role
! Notes
|-
|1932
|''[[The Midshipmaid]]'' 
|Golightly
|
|-
|rowspan="2"|1933
| ''[[The Ghost Camera]]'' 
|Ernest Elton
|
|-
|''[[Britannia of Billingsgate]]'' 
|Fred Bolton
|
|-
|rowspan="6"|1934
|''[[A Political Party]]'' 
|Tony Smithers
|
|-
|''[[The River Wolves]]'' 
|Peter Farrell
|
|-
|''[[Those Were the Days (1934 film)|Those Were the Days]]'' 
|Bobby Poskett
|
|-
|''[[The Lash (1934 film)|The Lash]]'' 
|Arthur Haughton
|
|-
|''[[Blind Justice (1934 film)|Blind Justice]]'' 
|Ralph Summers
|
|-
|''[[Doctor's Orders (film)|Doctor's Orders]]'' 
|Ronnie Blake
|
|-
|rowspan="4"|1935
|''[[Car of Dreams]]'' 
|Robert Miller
|
|-
|''[[Royal Cavalcade]]'' 
|Young Enlistee
|
|-
|''[[Brown on Resolution (film)|Brown on Resolution]]'' 
|Albert Brown
|(later reissued in the UK as ''Forever England'')
|-
|''[[Charing Cross Road (film)|Charing Cross Road]]'' 
|Tony
|
|-
|rowspan="2"|1936
|''[[The First Offence]]'' 
|Johnnie Penrose
| alternative title ''Bad Blood''
|-
|''[[Tudor Rose (film)|Tudor Rose]]'' 
|Lord Guilford Dudley
| Released as ''Nine Days a Queen'' in USA
|-
|rowspan="2"|1937
| ''[[O.H.M.S. (film)|O.H.M.S.]]'' 
|Cpl. Bert Dawson
|
|-
|''[[The Green Cockatoo]]'' 
|Jim Connor
|
|-
|1939
|''[[Goodbye, Mr. Chips (1939 film)|Goodbye, Mr Chips]]'' 
|Peter Colley – as a Young Man
|
|-
| rowspan="2"|1941
|''[[Old Bill and Son]]'' 
|Young Bill Busby
|
|-
|''[[Cottage to Let]]'' 
| Flt. Lieutenant Perry
|
|-
|rowspan="4"|1942
|''[[The Black Sheep of Whitehall]]'' 
| Bobby Jessop
|
|-
|''[[The Big Blockade]]'' 
|Tom
|
|-
|''[[In Which We Serve]]'' 
|Ordinary Seaman Blake
|(with daughter [[Juliet Mills]])
|-
|''[[The Young Mr. Pitt]]'' 
|William Wilberforce
|
|-
|1943
|''[[We Dive at Dawn]]'' 
|Lt. Taylor, R.N.
|
|-
|rowspan="2"|1944
|''[[This Happy Breed (film)|This Happy Breed]]'' 
|Billy Mitchell
|
|-
|Victory Wedding
|Bill Clark
|Short<ref>[https://web.archive.org/web/20190513224808/http://www.bfi.org.uk/films-tv-people/4ce2b6a1ef1f6 Victory Wedding]. British Film Institute. Retrieved 29 April 2020</ref>
|-
|rowspan="2"|1945
|''[[Waterloo Road (film)|Waterloo Road]]'' 
|Jim Colter
|
|-
|''[[The Way to the Stars]]'' 
|Peter Penrose
|
|-
|1946
| ''[[Great Expectations (1946 film)|Great Expectations]]'' 
|Pip
|
|-
|rowspan="2"|1947
|''[[So Well Remembered]]'' 
|George Boswell
|(with daughters [[Juliet Mills]] and [[Hayley Mills]])
|-
|''[[The October Man]]'' 
|Jim Ackland
|
|-
|1948
| ''[[Scott of the Antarctic (film)|Scott of the Antarctic]]'' 
|Captain Scott<br>Captain R.F. Scott R.N.
|
|-
|rowspan="2"|1949
| ''[[The History of Mr. Polly (film)|The History of Mr Polly]]''
|Alfred Polly
|
|-
|''[[The Rocking Horse Winner (film)|The Rocking Horse Winner]]''
|Bassett
| (also produced)
|-
|1950
|''[[Morning Departure]]'' 
|Lt. Commander Armstrong
|
|-
|1951
|''[[Mr. Denning Drives North|Mr Denning Drives North]]'' 
|Tom Denning
|
|-
|1952
|''[[The Gentle Gunman]]'' 
|Terrence Sullivan
|
|-
|1953
|''[[The Long Memory]]'' 
|Phillip Davidson
|
|-
|1954
| ''[[Hobson's Choice (1954 film)|Hobson's Choice]]'' 
|Willie Mossop
|Nominated-[[BAFTA Award for Best Actor in a Leading Role]]
|-
|rowspan="4"|1955
|''[[The Colditz Story]]'' 
|Pat Reid
|
|-
|''[[The End of the Affair (1955 film)|The End of the Affair]]'' 
|Albert Parkis
|
|-
|''[[Above Us the Waves]]'' 
|Commander Fraser
|
|-
|''[[Escapade (1955 film)|Escapade]]'' 
|John Hampden
|
|-
|rowspan="4"|1956
|''[[The Baby and the Battleship]]'' 
|Puncher Roberts
|
|-
| ''[[War and Peace (1956 film)|War and Peace]]'' 
|Platon Karataev
|
|-
|''[[Around the World in 80 Days (1956 film)|Around the World in 80 Days]]'' 
|London Carriage Driver
|
|-
|''[[It's Great to Be Young (1956 film)|It's Great to Be Young]]'' 
|Mr Dingle
|
|-
|rowspan="2"|1957
|''[[Town on Trial]]'' 
|Supt Mike Halloran
|
|-
|''[[The Vicious Circle (1957 film)|The Vicious Circle]]'' 
|Dr Howard Latimer
|
|-
|rowspan="3"|1958
| ''[[Dunkirk (1958 film)|Dunkirk]]'' 
|Corporal Binns
|
|-
|''[[Ice Cold in Alex]]'' 
|Captain Anson RASC
|
|-
|''[[I Was Monty's Double (film)|I Was Monty's Double]]''
|Major Harvey
|(also titled ''Hell, Heaven or Hoboken'')
|-
|rowspan="2"|1959
|''[[Tiger Bay (1959 film)|Tiger Bay]]''
|Superintendent Graham
|(with daughter [[Hayley Mills]])
|-
|''[[Summer of the Seventeenth Doll (1959 film)|Summer of the Seventeenth Doll]]'' 
|Barney
|(also titled ''Season of Passion'')
|-
|rowspan="2"|1960
|''[[Tunes of Glory]]'' 
|Lt. Col. Basil Barrow (Battalion Commander)
| [[Volpi Cup for Best Actor]]<br>Nominated-[[BAFTA Award for Best Actor in a Leading Role]]
|-
|''[[Swiss Family Robinson (1960 film)|Swiss Family Robinson]]'' 
|William Robinson
|
|-
|rowspan="3"|1961
|''[[The Singer Not the Song]]'' 
|Father Michael Keogh
|
|-
|''[[The Parent Trap (1961 film)|The Parent Trap]]''
|Mitch Evers' Golf Caddy
|Uncredited
|-
|''[[Flame in the Streets]]'' 
|Jacko Palmer
|
|-
|rowspan="2"|1962
|''[[The Valiant (1962 film)|The Valiant]]'' 
|Captain Morgan
|
|-
|''[[Tiara Tahiti]]'' 
|Lt. Col. Clifford Southey
|
|-
|1964
|''[[The Chalk Garden (film)|The Chalk Garden]]'' 
|Maitland
|(with daughter [[Hayley Mills]])
|-
|rowspan="3"|1965
|''[[Operation Crossbow (film)|Operation Crossbow]]'' 
|Gen. Boyd
|
|-
|''[[The Truth About Spring]]''
|Tommy Tyler
|(with daughter [[Hayley Mills]])
|-
|''[[King Rat (film)|King Rat]]'' 
|Smedley – Taylor
|
|-
|rowspan="2"|1966
|''[[The Wrong Box]]'' 
|Masterman Finsbury
|
|-
|''[[The Family Way]]'' 
|Ezra Fitton
|(with daughter [[Hayley Mills]])<br>[[Silver Shell for Best Actor]] (tied with [[Maurice Ronet]] for ''[[The Champagne Murders]]'') at the [[San Sebastián International Film Festival]]
|-
|rowspan="2"|1967
|''[[Africa Texas Style]]'' 
|Wing Commander Hayes
|
|-
|''[[Chuka (film)|Chuka]]'' 
|Colonel Stuart Valois
|
|-
|rowspan="2"|1968
| ''[[A Black Veil for Lisa]]'' 
|Inspector Franz Bulon
|
|-
|''[[Emma Hamilton (film)|Emma Hamilton]]'' 
|Sir William Hamilton
|
|-
|rowspan="2"|1969
| ''[[Oh! What a Lovely War]]'' 
|Field Marshal Sir Douglas Haig
|
|-
|''[[Run Wild, Run Free]]'' 
|The Moorman
|
|-
|rowspan="2"|1970
| ''[[Adam's Woman]]'' 
|Sir Phillip MacDonald
|
|-
| ''[[Ryan's Daughter]]'' 
| Michael
| [[Academy Award for Best Supporting Actor]]<br>[[Golden Globe Award for Best Supporting Actor – Motion Picture]]<br>Kansas City Film Critics Circle Award for Best Supporting Actor<br> Nominated-[[BAFTA Award for Best Supporting Actor]]
|-
|1971
| ''[[Dulcima]]'' 
|Mr Parker
|
|-
|rowspan="2"|1972
| ''[[Young Winston]]'' 
|General Kitchener
|
|-
| ''[[Lady Caroline Lamb (film)|Lady Caroline Lamb]]'' 
|Canning
|
|-
|1973
|''[[Oklahoma Crude (film)|Oklahoma Crude]]'' 
|Cleon Doyle
|
|-
|1975
| ''[[The Human Factor (1975 film)|The Human Factor]]'' 
|Mike McAllister
|
|-
|1976
|''[[Trial by Combat (film)|Trial by Combat]]'' 
|Colonel Bertie Cook
| (also titled ''A Dirty Knight's Work'')
|-
|1977
|''[[The Devil's Advocate (1977 film)|The Devil's Advocate]]'' 
|Blaise Meredith
|
|-
|rowspan="2"|1978
| ''[[The Big Sleep (1978 film)|The Big Sleep]]'' 
|Inspector Jim Carson
|
|-
|''[[The Thirty Nine Steps (1978 film)|The Thirty Nine Steps]]'' 
|Scudder
|
|-
|rowspan="2"|1979
|''[[Quatermass (TV serial)|The Quatermass Conclusion]]'' 
|Professor Bernard Quatermass
|
|-
| ''[[Zulu Dawn]]'' 
|Sir Henry Bartle Frere
|
|-
|1982
|''[[Gandhi (film)|Gandhi]]'' 
|The Viceroy Baron Chelmsford
|
|-
|1983
|''[[Sahara (1983 film)|Sahara]]'' 
|Cambridge
|
|-
|1986
| ''[[When the Wind Blows (1986 film)|When the Wind Blows]]'' 
|Jim
|Voice
|-
|1987
|''[[Who's That Girl (1987 film)|Who's That Girl]]'' 
|Montgomery Bell
|(credited as Sir John Mills)
|-
|1993
| ''[[The Big Freeze (1993 film)|The Big Freeze]]'' 
|Dapper man
|
|-
|1994
|''[[Deadly Advice]]'' 
|Jack the Ripper
|
|-
|1995
|''[[The Grotesque (film)|The Grotesque]]'' 
|Sir Edward Cleghorn
|(also titled ''Gentleman Don't Eat Poets'')
|-
|1996
| ''[[Hamlet (1996 film)|Hamlet]]'' 
|Old Norway
|
|-
|1997
| ''[[Bean (film)|Bean]]'' 
|Chairman
| (credited as Sir John Mills)
|-
|1998
| ''[[Cats (1998 film)|Cats]]'' 
| [[Gus: The Theatre Cat|Gus the Theater Cat]]
|
|-
|2003
|''[[Bright Young Things (film)|Bright Young Things]]'' 
| Gentleman
|
|-
|2005
|''Lights2'' 
| The Tramp
| Cinematographer Jack Cardiff (previously worked on Scott of The Antarctic), (final film role)
|}